ARROW-14510: [R] [CI] ensure that docker runs don't use host-built artifacts#11944
ARROW-14510: [R] [CI] ensure that docker runs don't use host-built artifacts#11944jonkeane wants to merge 3 commits into
Conversation
|
@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer test-fedora-r-clang-sanitizer test-r-linux-valgrind test-ubuntu-default-docs |
|
Revision: f37cc99 Submitted crossbow builds: ursacomputing/crossbow @ actions-1291
|
|
@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer test-fedora-r-clang-sanitizer test-r-linux-valgrind test-ubuntu-default-docs |
|
Revision: 450f251 Submitted crossbow builds: ursacomputing/crossbow @ actions-1292
|
|
@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer test-fedora-r-clang-sanitizer test-r-linux-valgrind test-ubuntu-default-docs |
|
Revision: 01b8dc7 Submitted crossbow builds: ursacomputing/crossbow @ actions-1293
|
jonkeane
changed the title
jonkeane
changed the title
|
The two sanitizer failures are legit (and not caused by this ticket — they look like they are from #11850) |
thisisnic
left a comment
thisisnic
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM
|
|
||
| popd | ||
|
|
||
| popd |
There was a problem hiding this comment.
Is this a typo or is it needed again here?
There was a problem hiding this comment.
Are popds even needed here? My assumption is shell scripts don't influence the state after completing.
There was a problem hiding this comment.
I added another pushd up above, so I added this down here to match the flow — but you're right that this shouldn't change the state or anything so is probably not needed.
rok
left a comment
rok
left a comment
There was a problem hiding this comment.
LGTM!
Out of curiosity - wouldn't ${R_BIN} CMD INSTALL --clean ${INSTALL_ARGS} as suggested here also solve this problem? (Sorry for my ignorance if this is a completely off mark.)
|
|
||
| popd | ||
|
|
||
| popd |
There was a problem hiding this comment.
Are popds even needed here? My assumption is shell scripts don't influence the state after completing.
|
Re: |
Got it! That makes sense, thanks for the explanation :). |
|
Benchmark runs are scheduled for baseline = 7cf7442 and contender = acce836. acce836 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
4 participants
No description provided.